Add reactNativeArchitectures support to expo-build-properties
deku_nattsu
Having one source of truth for both android studio and gradle would be nice, rather than having to always set the env variable or edit gradle.properties in the android folder which doesn't preserve the changes when running
prebuild --clean
.
Brent Vatne
hi there! we could add this. note that the default behavior is to only build for the target architecture with
npx expo run:android
- if you want to build for all architectures, pass in --all-arch
eg: npx expo run:android --all-arch
. knowing this, does that solve your issue or are you actually specifying a different set of architectures?also note that you can modify reactNativeArchitectures in gradle.properties by using the gradleProperties mod: https://docs.expo.dev/config-plugins/mods/#available-mod-plugins
deku_nattsu
hi Brent Vatne yeah that would solve the issue. honestly TIL about mod plugins and it seems like that's also a solution for this, I'll give it a try at night thanks for that!
So at this point it is just a matter of DX for it to be added to expo-build-properties.
Brent Vatne
deku_nattsu - can you elaborate why you need to control it through expo-build-properties when
npx expo run:android
already defaults to only the active arch and --all-arch
allows you to invert that?deku_nattsu
Brent Vatne i want to control it through expo-build-properties so i can set only the archs i am interested in (in my case dropping x86) when building apk with android studio or gradlew.
Brent Vatne
deku_nattsu - that makes sense! i made a task for this internally but given that you can build this right now by just doing a simple config plugin, i set it to low priority. if you'd like to open a pr for it that would be welcome
deku_nattsu
Brent Vatne Okay i might try that, thank you